chore(redundancy): increment fetchedCnt before closing wait channel#5505
Open
martinconic wants to merge 1 commit into
Open
chore(redundancy): increment fetchedCnt before closing wait channel#5505martinconic wants to merge 1 commit into
martinconic wants to merge 1 commit into
Conversation
martinconic
requested review from
acud,
akrem-chabchoub,
gacevicljubisa,
janos and
sbackend123
akrem-chabchoub
approved these changes
Jun 19, 2026
Contributor
|
is this not covered by this PR? #5449 |
Contributor
Author
Seeing the other efforts maybe this is not the fix for the flaky pkg/file/redundancy/getter failures and maybe 5449 fixes the underlying issue. This is a smaller, defensive ordering improvement that could stand on its own. |
martinconic
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Description
Independent ordering-correctness change in decoder.fetch().
On the successful-retrieval path the per-shard wait channel was closed before fetchedCnt was incremented
Open API Spec Version Changes (if applicable)
Motivation and Context (Optional)
Related Issue (Optional)
Screenshots (if appropriate):
AI Disclosure